Repo2docker container tests #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where the default python is 3.7, but we have used 3.9 for the demo.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
[some duplication here]
(has now specific workflow)
Owner
|
Nice work, @RobertRosca . I did complete this (to a functional level) hopefully in the way you had planned this. Do you want to look at it before I merge? |
Collaborator
Author
|
Sure, I'll have a look now |
RobertRosca
commented
Jan 5, 2022
Collaborator
Author
RobertRosca
left a comment
RobertRosca
left a comment
There was a problem hiding this comment.
Apart from the makefile/docker image name comments, LGTM (to both of us I guess 😂)
Co-authored-by: Robert Rosca <32569096+RobertRosca@users.noreply.github.com>
Co-authored-by: Robert Rosca <32569096+RobertRosca@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another job to the staging workflow called
repo2docker-build-and-testwhich builds a docker container with repo2docker usingjupyterhub/repo2docker-actionand then executes nbval tests inside that container.This checks that running the notebooks on MyBinder works correctly.