Skip to content

Add/Remove Scintilla shortcuts for MacOS too#368

Merged
fantaisie-software merged 4 commits intofantaisie-software:develfrom
ChrisRfr:devel
Apr 3, 2026
Merged

Add/Remove Scintilla shortcuts for MacOS too#368
fantaisie-software merged 4 commits intofantaisie-software:develfrom
ChrisRfr:devel

Conversation

@ChrisRfr
Copy link
Copy Markdown
Contributor

@ChrisRfr ChrisRfr commented Apr 2, 2026

Add/Remove Scintilla shortcuts on #SCN_FOCUSIN, #SCN_FOCUSOUT for MacOS too, using #PB_Shortcut_Command (rather than #PB_Shortcut_Control for windows and Linux).

It should be good, but I don't have a Mac to test it!

Add/Remove Scintilla shortcuts on #SCN_FOCUSIN/FOCUSOUT for MacOS using #PB_Shortcut_Command.
It should be good, but I don't have a Mac to test it!
@kenmo-pb
Copy link
Copy Markdown
Contributor

kenmo-pb commented Apr 2, 2026

Even simpler, you can just use #PB_Shortcut_Command for all, because on Windows and Linux it is equivalent to #PB_Shortcut_Control. You can check the values yourself. See the help for AddKeyboardShortcut() about this 👍

@ChrisRfr
Copy link
Copy Markdown
Contributor Author

ChrisRfr commented Apr 2, 2026

I agree again (simpler but probably less descriptive)👍
But I do it like it is in ShortcutManagement.pb (line 423+) with the CompilerIf #CompileLinux | #CompileWindows -> CompilerElse for MacOS
Use #PB_Shortcut_Command could be good, by adding the comment: "; #PB_Shortcut_Command will act like #PB_Shortcut_Control on non-macOS "
Done, thanks

ps; Thanks kenmo-pb for following the filter added to the project management and to help improve it with the default behavior for strings, now 👍

ChrisRfr added 3 commits April 2, 2026 14:03
Keep PreferencesFile$, TemplatesFile$,... if already defined using -p “PreferenceFile”, -t “TemplatesFile”,... before /PORTABLE switch
Undo Cmdline preserve previous settings with /PORTABLE switch at the end.
I'm going to add it to a new branch
@fantaisie-software
Copy link
Copy Markdown
Owner

Looks good !

@fantaisie-software fantaisie-software merged commit 6d89348 into fantaisie-software:devel Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants