Bump internet2 and microservices to v0.8#589
Merged
h4sh3d merged 5 commits intofarcaster-project:mainfrom Jul 26, 2022
Merged
Conversation
Closed
sedited
force-pushed
the
depsInet0.8
branch
3 times, most recently
from
4f971bb to
0c9d2d2
Compare
This was
linked to
issues
Jul 25, 2022
sedited
force-pushed
the
depsInet0.8
branch
4 times, most recently
from
770c253 to
ef7b455
Compare
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
=====================================
Coverage 9.2% 9.2%
=====================================
Files 34 32 -2
Lines 10744 10690 -54
=====================================
- Hits 990 988 -2
+ Misses 9754 9702 -52
Continue to review full report at Codecov.
|
h4sh3d
reviewed
Jul 26, 2022
h4sh3d
reviewed
Jul 26, 2022
| #[macro_use] | ||
| extern crate amplify_derive; | ||
| #[macro_use] | ||
| extern crate lnpbp; |
h4sh3d
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does extensive changes to the node by removing the lightning dependencies (which became annoying to keep with the new microservices api definitons) and switching to the new internet2 address format.
With internet2 dropping most of the lightning-specific behavior, we could get rid of things like the default lightning port and lightning compatibility messages like
PingandPong. This allowed me to remove the lightning dependencies entirely.The minimum supported rust version had to be bumped because internet2 0.8 requires it.
I also got rid of the reply and message file that we practically did not use. This mandated however that we define our own
Failuretype, which was another bi-product of navigating around an otherwise complicated change introduced bymicroservices 0.8. I added a TODO to add further failure codes eventually.