Skip to content

Release: Prepare for mainnet#608

Merged
h4sh3d merged 3 commits intofarcaster-project:mainfrom
sedited:prepareMainnet
Aug 1, 2022
Merged

Release: Prepare for mainnet#608
h4sh3d merged 3 commits intofarcaster-project:mainfrom
sedited:prepareMainnet

Conversation

@sedited
Copy link
Copy Markdown
Contributor

@sedited sedited commented Jul 29, 2022

Still needs:

  • Validate network of the passed in addresses
  • Check amounts on taker side

Edit:
This removes the make swap abort if the network is neither local nor testnet. Instead, we now validate the amounts of the offer for the Maker and Taker. Bitcoin is capped to 0.01 BTC and Monero to 2 XMR. Additionally this PR introduces checks that the user-supplied addresses are indeed usable on the selected network.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #608 (009b35f) into main (ad57774) will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@          Coverage Diff          @@
##            main    #608   +/-   ##
=====================================
  Coverage    9.4%    9.4%           
=====================================
  Files         32      32           
  Lines      10510   10504    -6     
=====================================
  Hits         986     986           
+ Misses      9524    9518    -6     
Impacted Files Coverage Δ
src/cli/command.rs 0.0% <0.0%> (ø)
src/service.rs 7.0% <0.0%> (-<0.1%) ⬇️
src/cli/opts.rs 0.0% <0.0%> (ø)
src/lib.rs 4.8% <0.0%> (+<0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad57774...009b35f. Read the comment docs.

sedited added 2 commits August 1, 2022 16:47
Add amount checks for Mainnet Monero and Bitcoin for both Taker and
Maker.
@sedited sedited marked this pull request as ready for review August 1, 2022 16:20
Copy link
Copy Markdown
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@h4sh3d h4sh3d merged commit 154eb91 into farcaster-project:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants