Release: Prepare for mainnet#608
Merged
h4sh3d merged 3 commits intofarcaster-project:mainfrom Aug 1, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
=====================================
Coverage 9.4% 9.4%
=====================================
Files 32 32
Lines 10510 10504 -6
=====================================
Hits 986 986
+ Misses 9524 9518 -6
Continue to review full report at Codecov.
|
Add amount checks for Mainnet Monero and Bitcoin for both Taker and Maker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs:Validate network of the passed in addressesCheck amounts on taker sideEdit:
This removes the make swap abort if the network is neither local nor testnet. Instead, we now validate the amounts of the offer for the Maker and Taker. Bitcoin is capped to 0.01 BTC and Monero to 2 XMR. Additionally this PR introduces checks that the user-supplied addresses are indeed usable on the selected network.