Bump code to monero-rpc-rs and bump Monero clients to 0.18.0.0#620
Bump code to monero-rpc-rs and bump Monero clients to 0.18.0.0#620sedited merged 2 commits intofarcaster-project:mainfrom
Conversation
LeoNero
force-pushed
the
bump/monero-rpc-rs
branch
from
9b148dd to
2a1cdd7
Compare
Codecov Report
@@ Coverage Diff @@
## main #620 +/- ##
=====================================
Coverage 9.3% 9.3%
=====================================
Files 32 32
Lines 10509 10506 -3
=====================================
Hits 982 982
+ Misses 9527 9524 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
| drop(lock); | ||
| let delta_balance = after_balance.balance - before_balance.balance; | ||
| assert!(delta_balance > 999660000000); | ||
| assert!(delta_balance.as_pico() > 999660000000); |
There was a problem hiding this comment.
Nit: I'd prefer doing the conversion on the other side, so we don't change the data or type to be tested.
|
I'm surprised this did not lead to more type improvements in the monero syncer, but we can figure out how to handle the remaining raw types at a later stage. Anyway, nice work and I am glad this went in so seemingly painless compared to our Bitcoin version bump that we are currently working on. ACK once the nit is addressed or further rationalized. |
LeoNero
force-pushed
the
bump/monero-rpc-rs
branch
from
2a1cdd7 to
1f2ba93
Compare
|
@TheCharlatan addressed. |
|
LGTM, will rebase #614 |
|
Oh, I see now that you didn't updated the CI containers in cc: @TheCharlatan |
|
Oh damn, I missed that as well :O |
|
oh will update! |
|
I think my vim extension that searches words in the files is missing |
4 participants
This bumps Monero clients to 0.18.0.0 like #614 does. If the other PR gets merged first, I'll update this one.