Skip to content

farcasterd: syncers refactor following h4sh3d recommendation#624

Merged
h4sh3d merged 1 commit intofarcaster-project:mainfrom
zkao:syncers_refactor
Aug 3, 2022
Merged

farcasterd: syncers refactor following h4sh3d recommendation#624
h4sh3d merged 1 commit intofarcaster-project:mainfrom
zkao:syncers_refactor

Conversation

@zkao
Copy link
Copy Markdown
Member

@zkao zkao commented Aug 2, 2022

No description provided.

@zkao zkao linked an issue Aug 2, 2022 that may be closed by this pull request
@zkao
Copy link
Copy Markdown
Member Author

zkao commented Aug 2, 2022

@h4sh3d really nice indeed!

@zkao
Copy link
Copy Markdown
Member Author

zkao commented Aug 2, 2022

thank you for taking your time to describe how to do it

@zkao zkao force-pushed the syncers_refactor branch from 6e345dc to dfee3ec Compare August 2, 2022 16:02
@h4sh3d
Copy link
Copy Markdown
Member

h4sh3d commented Aug 2, 2022

CI will probably fail because of lws, after #627 get merged rebase and it should be fine again.

@zkao zkao force-pushed the syncers_refactor branch from dfee3ec to a946f1f Compare August 2, 2022 18:20
@zkao zkao force-pushed the syncers_refactor branch from a946f1f to c7bafed Compare August 2, 2022 18:21
Copy link
Copy Markdown
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@h4sh3d h4sh3d merged commit 87eff63 into farcaster-project:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syncers should be type Syncers = HashMap<...>

2 participants