Update PlanDTO to allow nullable readonly properties for send_invoice…#17
Merged
Update PlanDTO to allow nullable readonly properties for send_invoice…#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
PlanDTOclass in thesrc/DataTransferObjects/Recurring/PlanDTO.phpfile to allow certain properties to be nullable. The most important changes include modifying thesend_invoicesandsend_smsproperties to acceptnullvalues.Changes to
PlanDTOclass:src/DataTransferObjects/Recurring/PlanDTO.php: Modified thesend_invoicesproperty to be of typebool|nullinstead of justbool.src/DataTransferObjects/Recurring/PlanDTO.php: Modified thesend_smsproperty to be of typebool|nullinstead of justbool.…s and send_sms