fix(rust): fix SIMDe configuration on aarch64 platforms when not installed yet#63
Merged
nyurik merged 7 commits intofast-pack:mainfrom Feb 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Rust build script so the CXX bridge compilation on aarch64 mirrors FastPFOR’s SIMDe configuration when SIMDe is fetched by CMake (instead of preinstalled), and updates the README to reflect that SIMDe is typically not a manual dependency on Apple Silicon.
Changes:
- Update
build.rsto reuse CMake-fetched SIMDe headers and add theSIMDE_ENABLE_NATIVE_ALIASESdefine for the CXX bridge on aarch64. - Add a build-time warning when SIMDe headers can’t be found in the CMake output.
- Update README platform instructions to make SIMDe installation optional and describe fallback options.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build.rs | Detect aarch64 and try to add SIMDe include path + compile define to the CXX bridge compilation. |
| README.md | Update build prerequisites to make SIMDe optional and clarify macOS/Apple Silicon expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Feb 25, 2026
nyurik
pushed a commit
that referenced
this pull request
Feb 25, 2026
After #63, installing SIMDe should not be necessary. So, this pull request simplifies the CI settings by removing `brew install simde`.
CommanderStorm
added a commit
to maplibre/maplibre-tile-spec
that referenced
this pull request
Feb 25, 2026
I believe fast-pack/FastPFOR-rs#62 and fast-pack/FastPFOR-rs#63 fixed the compilation problem on aarch64 platforms. Now that FastPFOR is updated to v0.7, I think we can enable build on Arm Linux and Arm macOS again (At least, I have no difficulty to build this on my macOS). (But, I don't know what issues "Currently, seems flaky" comment refers to, so it's possible I miss some problems...) --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Frank Elsinga <frank@elsinga.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(In order to fix build on aarch64 platfroms, #62 is still needed in addition to this change)
I was wondering why the FastPFOR-rs repository tests macOS runner without installing SIMDe; FastPFOR fetches and build SIMDe automatically. However, it seems the include path and define are not configured correctly when with
cxx_build::bridge(). So, this pull request attempts to fix it by manually doing the equivalent to this part ofcmake_modules/simde.cmake.