Address static analyzer warnings #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lemire merged 2 commits into fast-pack:master from elshize:unused-prev

Oct 21, 2019

Contributor

elshize commented Oct 20, 2019

There were 2 assignments to a variable that was never read afterwards.
To quote the C++ reference

For negative a, the behavior of a << b is undefined.

and ~0 is a negative int, so I switched it to 0u.

elshize added 2 commits

October 20, 2019 15:20


          Remove unused assignments

42142a2


          Negate 0u to ensure there is no undefined behavior

4f132a4

Member

lemire commented Oct 21, 2019

Fantastic!

lemire merged commit 8030e38 into fast-pack:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet