Skip to content

Address static analyzer warnings #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 2 commits into from
Oct 21, 2019
Merged

Address static analyzer warnings #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42142a2
Remove unused assignments
elshize Oct 20, 2019
4f132a4
Negate 0u to ensure there is no undefined behavior
elshize Oct 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/streamvbyte.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ uint8_t *svb_insert_scalar_d1_init(uint8_t *keyPtr, uint8_t *dataPtr,
dataPtr = dataPtrPrev;

// shift keys 2 bits "to the right"
uint32_t mask_hi = key & (~0 << shift);
uint32_t mask_hi = key & (~0u << shift);
uint32_t mask_lo = key & ((1 << shift) - 1);
key = (mask_hi << 2) | mask_lo;
uint32_t carry_bits, prev_carry_bits = (key & (3 << 8)) >> 8;
Expand Down Expand Up @@ -761,7 +761,7 @@ uint8_t *svb_decode_avx_d1_init(uint32_t *out, uint8_t *__restrict__ keyPtr,
Data = _mm_cvtepu8_epi16(_mm_lddqu_si128((xmm_t *)(dataPtr + 16)));
Prev = _write_16bit_avx_d1(out + 16, Data, Prev);
Data = _mm_cvtepu8_epi16(_mm_loadl_epi64((xmm_t *)(dataPtr + 24)));
Prev = _write_16bit_avx_d1(out + 24, Data, Prev);
_write_16bit_avx_d1(out + 24, Data, Prev);
out += 32;
dataPtr += 32;

Expand All @@ -788,7 +788,7 @@ uint8_t *svb_decode_avx_d1_init(uint32_t *out, uint8_t *__restrict__ keyPtr,
Data = _decode_avx((keys & 0x00FF), &dataPtr);
Prev = _write_avx_d1(out + 24, Data, Prev);
Data = _decode_avx((keys & 0xFF00) >> 8, &dataPtr);
Prev = _write_avx_d1(out + 28, Data, Prev);
_write_avx_d1(out + 28, Data, Prev);

out += 32;
}
Expand Down