library fixes: move functions out of headers or make them inline#27
Merged
lemire merged 1 commit intofast-pack:masterfrom Dec 10, 2020
Merged
library fixes: move functions out of headers or make them inline#27lemire merged 1 commit intofast-pack:masterfrom
lemire merged 1 commit intofast-pack:masterfrom
Conversation
Member
|
Looks good to me. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes linking issues with clients/users of the SIMDCompressionAndIntersection library . When including "codecfactory.h" in more than one client object file, multiple linking errors would result due to non-inline functions and data located in header files. I moved larger functions to .cpp files, and specified "inline" for smaller functions. I spot-checked the resulting performance and didn't notice any differences.