feat: use more compact default Debug format#52
Merged
andylokandy merged 1 commit intofast:mainfrom May 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates exn’s default Debug formatting to render error trees more compactly by removing the extra blank separator line and switching to box-drawing characters.
Changes:
- Update
write_exnto print child frames using├──/└──connectors and│indentation. - Refresh Insta snapshots to match the new compact
Debugoutput across linear and tree-shaped error graphs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| exn/src/debug.rs | Changes the Debug tree rendering to use box-drawing connectors and removes the extra separator line. |
| exn/tests/snapshots/main__tree_error.snap | Updates expected tree-shaped debug output to new connector style. |
| exn/tests/snapshots/main__linear_error.snap | Updates expected linear-chain debug output to new connector style. |
| exn/tests/snapshots/main__result_ext.snap | Updates expected debug output for ResultExt case. |
| exn/tests/snapshots/main__new_with_source.snap | Updates expected debug output for Exn::new with source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tisonkun
reviewed
Apr 21, 2026
2065b51 to
2f7daec
Compare
Contributor
Author
|
I see, there are snapshot tests in the example. I'll fix those too. |
2f7daec to
dc53f0c
Compare
Contributor
|
Thanks for the update. Could you rebase this onto the latest main, resolve the conflict, and refresh the tests? Looks like maintainers cannot push to this branch directly, so we'll need your help with the update. |
andylokandy
reviewed
May 4, 2026
Contributor
|
@kanru Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the empty line between errors and use box-drawing characters for compact rendering.