feat: display target instead of module_path#82
Merged
Conversation
tisonkun
reviewed
Nov 29, 2024
Contributor
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Generally looks good. May we add some background to this PR about the difference between target and module_path?
Also, this should deserve a changelog entry. You can add a new [Unrelease] section and add a new entry.
tisonkun
approved these changes
Dec 3, 2024
Contributor
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
LGTM.
rust-lang/log#390 target is a customzable field that is default to module_path.
Contributor
|
Shall we release a 0.19.0 for this now? Or I may expect to release it next week for stashing any other patches. |
Contributor
Author
|
I'm ok with holding release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
target is usually identical to target, while target can be manually altered like
log::debug!(target: "request", "handling request"). And target can be used in envfilter expression likeINFO,request=DEBUG.