Conversation
There was a problem hiding this comment.
Pull request overview
This PR syncs a couple of upstream oneshot-crate changes into mea’s oneshot implementation, including small internal API adjustments and additional regression tests around sender/receiver lifecycle and message availability.
Changes:
- Add tests verifying receiver closure when the sender is dropped and
has_message()behavior. - Refine internal channel message access (
Channel::message) to return&Tand updateSendError::as_inneraccordingly. - Add/expand safety commentary and adjust
SendError<T>debug output to usetype_name::<T>().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mea/src/oneshot/tests.rs |
Adds new tests for sender-drop closure propagation and has_message() semantics. |
mea/src/oneshot/mod.rs |
Adjusts internal message accessor and SendError impls/comments; adds Receiver<T>: Unpin impl and tweaks Debug. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still lack for reviewing other changes, like: