Skip to content

Remove redirect route name in fastapi integration #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

Remove redirect route name in fastapi integration #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions fastapi_oauth20/integrations/fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,15 @@ def __init__(
client: OAuth20Base,
*,
redirect_uri: str | None = None,
redirect_route_name: str | None = None,
):
"""
OAuth2 authorization callback dependency injection

:param client: A client base on OAuth20Base.
:param redirect_uri: OAuth2 callback full URL.
:param redirect_route_name: OAuth2 callback route name, as defined by the route decorator 'name' parameter.
"""
assert (redirect_uri is None and redirect_route_name is not None) or (
redirect_uri is not None and redirect_route_name is None
), 'FastAPIOAuth20 redirect_uri and oauth2_callback_route_name cannot be defined at the same time.'
self.client = client
self.redirect_uri = redirect_uri
self.redirect_route_name = redirect_route_name

async def __call__(
self,
Expand All @@ -60,15 +54,10 @@ async def __call__(
detail=error if error is not None else None,
)

if self.redirect_route_name:
redirect_url = str(request.url_for(self.redirect_route_name))
else:
redirect_url = self.redirect_uri

try:
access_token = await self.client.get_access_token(
code=code,
redirect_uri=redirect_url,
redirect_uri=self.redirect_uri,
code_verifier=code_verifier,
)
except (HTTPXOAuth20Error, AccessTokenError) as e:
Expand Down