Merge pull request #42 from fastapi-startkit/has-many-throgh-relation…#43
Merged
Conversation
…ships feat: polymorphic relationship
- Remove stale `from dumpdie import dd` debug import from MorphTo.py - Fix compile_alter_sql mutating diff.from_table.added_columns in place via .pop() and .update(), causing KeyError and wrong column lists when to_sql() is called more than once (e.g. __aexit__ + test assertion). Work on dict copies so each call produces correct idempotent output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The root .gitignore had **/.env which prevented the example app .env from being committed. CI clones a fresh repo with no .env files, so resolve_environment raised "Unable to determine environment." for all config-app tests. Added !example/**/.env negation and force-tracked the config-app .env (safe to commit — it contains only demo values). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Instead of tracking .env directly, add .env.example with safe defaults and copy it in the CI workflow before running tests. This follows the standard convention — .env stays gitignored, .env.example is the committed template. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ships
feat: polymorphic relationship