Skip to content

Add paths to trigger by docs changes#1023

Closed
peaceiris wants to merge 1 commit intofastapi:masterfrom
peaceiris:patch-1
Closed

Add paths to trigger by docs changes#1023
peaceiris wants to merge 1 commit intofastapi:masterfrom
peaceiris:patch-1

Conversation

@peaceiris
Copy link

@peaceiris peaceiris commented Feb 22, 2020

The title says it all.

@peaceiris peaceiris requested a review from tiangolo February 22, 2020 14:31
@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #1023 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1023   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          294       294           
  Lines         7732      7732           
=========================================
  Hits          7732      7732           
Impacted Files Coverage Δ
fastapi/concurrency.py 100.00% <0.00%> (ø) ⬆️
tests/main.py 100.00% <0.00%> (ø) ⬆️
tests/test_path.py 100.00% <0.00%> (ø) ⬆️
tests/test_query.py 100.00% <0.00%> (ø) ⬆️
tests/test_fakeasync.py 100.00% <0.00%> (ø) ⬆️
tests/test_application.py 100.00% <0.00%> (ø) ⬆️
tests/test_empty_router.py 100.00% <0.00%> (ø) ⬆️
docs/src/app_testing/main.py 100.00% <0.00%> (ø) ⬆️
tests/test_security_oauth2.py 100.00% <0.00%> (ø) ⬆️
docs/src/events/tutorial001.py 100.00% <0.00%> (ø) ⬆️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3c9b6...c1e9c4c. Read the comment docs.

@peaceiris peaceiris changed the title Add paths to be triggered by docs changes Add paths to trigger by docs changes Feb 22, 2020
@peaceiris peaceiris mentioned this pull request Feb 22, 2020
@tiangolo
Copy link
Member

Thanks! The issue with Netlify was actually related to the fact that PRs from forks don't have access to secrets. This was solved by #1046 and #1047 .

If this could be solved in a different way later I think it would be nice to be able to have docs previews for all PRs, possibly even if they don't modify the docs.

So I'm gonna pass this for now. But thanks for your contribution and interest! 🍰

@tiangolo tiangolo closed this Feb 29, 2020
@peaceiris peaceiris deleted the patch-1 branch February 29, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants