Skip to content

Conversation

@dbanty
Copy link
Contributor

@dbanty dbanty commented Mar 2, 2020

Fixes #1067

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #1068 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1068   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          331       331           
  Lines         8085      8085           
=========================================
  Hits          8085      8085           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025b38d...e747218. Read the comment docs.

@arimbr
Copy link
Contributor

arimbr commented Mar 20, 2020

Feels like we were other two to open a PR:
#1138
#1146

PR #1138 also changes hl_lines to match the highlighted code lines for the new block.

@dbanty
Copy link
Contributor Author

dbanty commented Mar 21, 2020

Yup, #1138 is better

@tiangolo
Copy link
Member

tiangolo commented Apr 6, 2020

Thanks everyone! 🍰

@dbanty dbanty deleted the patch-1 branch April 15, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GZip Middleware documentation wrong

4 participants