Skip to content

Conversation

@svlandeg
Copy link
Member

@svlandeg svlandeg commented May 3, 2024

As reported on Twitter: the link gave a 404 as the index.md page doesn't exist.

@tiangolo
Copy link
Member

tiangolo commented May 3, 2024

📝 Docs preview for commit 78b74c8 at: https://e57e68dc.fastapitiangolo.pages.dev

@svlandeg
Copy link
Member Author

svlandeg commented May 3, 2024

Link looks like it's fixed: https://e57e68dc.fastapitiangolo.pages.dev/fastapi-cli/

@alejsdev alejsdev changed the title Fix link in fastapi-cli.md ✏️ Fix link in fastapi-cli.md May 3, 2024
@alejsdev alejsdev added the docs Documentation about how to use FastAPI label May 3, 2024
@tiangolo
Copy link
Member

tiangolo commented May 3, 2024

Thank you! 🍰

I tweaked it a bit to remove the ../ and point to the index.md so that MkDocs can detect it as an internal file and warn when it points to a different place (I should include those checks in the tests 🤔 ).

@tiangolo
Copy link
Member

tiangolo commented May 3, 2024

📝 Docs preview for commit e038e49 at: https://5d1fa315.fastapitiangolo.pages.dev

@tiangolo tiangolo enabled auto-merge (squash) May 3, 2024 22:54
@tiangolo tiangolo merged commit 9406e82 into fastapi:master May 3, 2024
@svlandeg svlandeg deleted the fix/link branch May 4, 2024 13:30
hsuanchi pushed a commit to hsuanchi/fastapi that referenced this pull request May 26, 2024
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants