Skip to content

Conversation

@MartinEliasQ
Copy link
Contributor

This is the Spanish translation for the tutorial-user-guide index page. 🚀

@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #1244 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          226       226           
  Lines         6785      6785           
=========================================
  Hits          6785      6785           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e42a4...b3f7d70. Read the comment docs.

@alvaropernas
Copy link
Contributor

Looks really nice, those were mainly style addons.

@MartinEliasQ
Copy link
Contributor Author

I really appreciate your feedback @alvaropernas . I totally agree with your suggestions. Thank you.

@mariacamilagl
Copy link
Collaborator

Thank you for the great work @MartinEliasQ ! 🚀 🎉

I just wanted to ask you to please change the wording style to "tu" and to use it rather than "usted". For example, "copia el código" instead of "copie el código".

This was a wording choice @tiangolo asked for and it would really help us maintain consistency with the rest of the translations.

Otherwise, looks great! 👍 😄

@MartinEliasQ
Copy link
Contributor Author

Thank you @mariacamilagl.
The changes were added in the last commit.

Copy link
Collaborator

@mariacamilagl mariacamilagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinEliasQ Excelente! Muchas gracias por implementar los cambios. 👍 🚀 🎉

@tiangolo tiangolo merged commit 9812684 into fastapi:master May 16, 2020
@tiangolo
Copy link
Member

Awesome! Thanks for your contribution @MartinEliasQ ! 👏 🚀

And thanks @alvaropernas and @mariacamilagl for the comments and reviews! 🤓 ☕ 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants