Skip to content

Conversation

@ChihSeanHsu
Copy link
Contributor

@ChihSeanHsu ChihSeanHsu commented Jun 9, 2020

As I mentioned in #365, change behavior of if statement in dependency function get_cookie_or_client.

Add fill session in cookie in get function to let session is assign ready.

@ChihSeanHsu ChihSeanHsu force-pushed the doc/websocket_tutorial002_fix branch from a822c2f to be47987 Compare June 9, 2020 16:47
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #1540 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1540    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          227       234     +7     
  Lines         6810      7004   +194     
==========================================
+ Hits          6810      7004   +194     
Impacted Files Coverage Δ
.../test_tutorial/test_websockets/test_tutorial002.py 100.00% <100.00%> (ø)
tests/main.py 100.00% <0.00%> (ø)
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/docs.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
tests/test_application.py 100.00% <0.00%> (ø)
fastapi/security/__init__.py 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543ef77...71b5502. Read the comment docs.

@tiangolo tiangolo merged commit e430076 into fastapi:master Jun 13, 2020
@tiangolo
Copy link
Member

Thanks! 🚀

I updated it a bit to use a query parameter instead of header as it would be easier to test during development. 🤓

Thanks for your contribution! 🍰 ☕

@ChihSeanHsu ChihSeanHsu deleted the doc/websocket_tutorial002_fix branch June 14, 2020 17:25
@tiangolo tiangolo changed the title [BUG] Tutorial websocket doc example Tutorial websocket doc example Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tutorial websocket doc example

2 participants