Skip to content

Conversation

@rkbeatss
Copy link
Contributor

Changes based on suggestions on this PR implemented and more test coverage added

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #1560 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1560    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          227       232     +5     
  Lines         6810      6950   +140     
==========================================
+ Hits          6810      6950   +140     
Impacted Files Coverage Δ
fastapi/params.py 100.00% <100.00%> (ø)
tests/test_params_repr.py 100.00% <100.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
tests/test_dependency_class.py 100.00% <0.00%> (ø)
tests/test_deprecated_openapi_prefix.py 100.00% <0.00%> (ø)
...t_tutorial/test_behind_a_proxy/test_tutorial002.py 100.00% <0.00%> (ø)
...t_tutorial/test_behind_a_proxy/test_tutorial001.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543ef77...cf99f64. Read the comment docs.

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🎉

Very good job with all this @rkbeatss and @victorphoenix3 👏 👏 🚀 🎉

Thanks for your contribution! ☕ 🍰

return {} # pragma: no cover


@pytest.fixture(scope="function", params=test_data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clever! I actually didn't know of these fixtures with params 🤓 ✔️

@tiangolo tiangolo merged commit 3699e17 into fastapi:master Jun 12, 2020
@rkbeatss rkbeatss deleted the ReprParams branch June 16, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants