-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Implement changes for __repr__ tests #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove trailing whitespace Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Get remaining code for params.py
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 227 232 +5
Lines 6810 6950 +140
==========================================
+ Hits 6810 6950 +140
Continue to review full report at Codecov.
|
tiangolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 🎉
Very good job with all this @rkbeatss and @victorphoenix3 👏 👏 🚀 🎉
Thanks for your contribution! ☕ 🍰
| return {} # pragma: no cover | ||
|
|
||
|
|
||
| @pytest.fixture(scope="function", params=test_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clever! I actually didn't know of these fixtures with params 🤓 ✔️
Changes based on suggestions on this PR implemented and more test coverage added