Skip to content

Conversation

@acutaia
Copy link

@acutaia acutaia commented Aug 11, 2020

Updated starlette from 0.13.6 to 0.13.7
Cause version 0.13.7 fixes high memory usage when using BaseHTTPMiddleware middleware classes and streaming responses
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1875 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1875   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7070    -9     
=========================================
- Hits          7079      7070    -9     
Impacted Files Coverage Δ
fastapi/encoders.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77ea63...99d86b2. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit f11cf59 at: https://5f327c956d5d9f0191e31741--fastapi.netlify.app

@acutaia acutaia changed the title Update starlette version Update starlette version and add comprehension in encoders.py Aug 12, 2020
@acutaia
Copy link
Author

acutaia commented Aug 12, 2020

The tests for last commit where successful in my pc, i don't know why they failed here
test

@Kludex
Copy link
Member

Kludex commented Aug 12, 2020

Can you run black, please?
image

@github-actions
Copy link
Contributor

📝 Docs preview for commit 97d11b1 at: https://5f3430e411d03b998f48bde7--fastapi.netlify.app

@acutaia
Copy link
Author

acutaia commented Aug 12, 2020

Can you run black, please?
image

Sorry, i forgot. Done ;)

@github-actions
Copy link
Contributor

📝 Docs preview for commit d92451a at: https://5f344d1e87cbf1d48d9b6d26--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 93199a4 at: https://5f36391d0169f5d3976b6967--fastapi.netlify.app

Copy link
Contributor

@ycd ycd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acutaia
Copy link
Author

acutaia commented Aug 30, 2020

@ycd done 😉

@github-actions
Copy link
Contributor

📝 Docs preview for commit 99d86b2 at: https://5f4bc1c4b850664b6643d4a9--fastapi.netlify.app

@tiangolo
Copy link
Member

tiangolo commented Oct 3, 2021

Thanks for your effort! ☕

This was handled in another PR, the current Starlette version is 0.14.2, so I'm closing this one.

@tiangolo tiangolo closed this Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants