Skip to content

Create docs for Turkish Translations 🚀#1905

Merged
tiangolo merged 3 commits intofastapi:masterfrom
ycd:master
Aug 29, 2020
Merged

Create docs for Turkish Translations 🚀#1905
tiangolo merged 3 commits intofastapi:masterfrom
ycd:master

Conversation

@ycd
Copy link
Contributor

@ycd ycd commented Aug 17, 2020

I built docs for starting Turkish translations.

Issue: #1892

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #1905 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1905   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a689796...848e7f2. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8de0c76 at: https://5f39f552c3f45fef44e0d9a8--fastapi.netlify.app

@Kludex
Copy link
Member

Kludex commented Aug 17, 2020

Awesome! 🎉

Based on what I've seen, I recommend you to split your PR in two: one with the translation setup and another for the index.md.

The reason is because we want to have some reviews on the translation before being merged and the setup itself can be merged quickly because we don't need people who speak the language for it.

This reverts commit 8de0c76.
@ycd
Copy link
Contributor Author

ycd commented Aug 17, 2020

Thanks @Kludex 😄

I reverted my commit for translate index.md, i 'll open another PR for it.

@ycd ycd changed the title Create Turkish Translation Create docs for Turkish Translation Aug 17, 2020
@ycd ycd changed the title Create docs for Turkish Translation Create docs for Turkish Translations 🚀 Aug 17, 2020
@ycd ycd changed the title Create docs for Turkish Translations 🚀 Create docs for Turkish Translations 🚀 Aug 17, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit 848e7f2 at: https://5f3a65a872903ed2b6781e11--fastapi.netlify.app

@tiangolo tiangolo added lang-all Translations lang-tr Turkish translations labels Aug 29, 2020
@tiangolo tiangolo merged commit 4f0a3a9 into fastapi:master Aug 29, 2020
@tiangolo
Copy link
Member

Amazing! Thank you @ycd ! 🚀 🍰

And thanks @Kludex for the help as always 🙇 ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang-all Translations lang-tr Turkish translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants