Skip to content

Conversation

@SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 23, 2020

This PR translates the tutorial/body-updates.md to Japanese.
Please review tutorial/body-updates.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #1956 (6fb6be7) into master (8560151) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1956   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8108cd8...6fb6be7. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit f8fc6b3 at: https://5f424ef3a293b74cd74a9a20--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit 320c514 at: https://5f4cbf6086e53738dcedb21a--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it, with some comment (not request change)

SwftAlpc and others added 3 commits October 30, 2020 00:45
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 09aa236 at: https://5f9ae478363b750cccda38c4--fastapi.netlify.app

Copy link

@delhi09 delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiangolo tiangolo changed the title Add tutorial/body-updates.md 🌐 Add Japanese translation for Tutorial - Body - Updates Jan 9, 2021
@tiangolo
Copy link
Member

tiangolo commented Jan 9, 2021

Nice! Thank you @SwftAlpc ! 👏 👏 🍰

And thanks @tokusumi and @delhi09 for the reviews 🙇

@tiangolo tiangolo merged commit ca26f22 into fastapi:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants