Skip to content

🎨 Remove internal "type: ignore", now unnecessary#2424

Merged
tiangolo merged 1 commit intofastapi:masterfrom
AsakuraMizu:patch-1
Feb 7, 2021
Merged

🎨 Remove internal "type: ignore", now unnecessary#2424
tiangolo merged 1 commit intofastapi:masterfrom
AsakuraMizu:patch-1

Conversation

@AsakuraMizu
Copy link
Copy Markdown
Contributor

pydantic/pydantic#1739

This bug is fixed.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2020

Codecov Report

Merging #2424 (29e6de3) into master (cc99e23) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2424   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101           
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d550738...29e6de3. Read the comment docs.

@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 29e6de3 at: https://5fbf673799a34e39eb692583--fastapi.netlify.app

Copy link
Copy Markdown
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🎉

@tiangolo tiangolo changed the title Remove type: ignore 🎨 Remove internal "type: ignore", now unnecessary Feb 7, 2021
@tiangolo tiangolo merged commit f221373 into fastapi:master Feb 7, 2021
@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Feb 7, 2021

Awesome! Thanks @AsakuraMizu ! 🚀 🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants