-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Fixed incorrect default value for type Set #2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect default value for type Set #2646
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2646 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 243 243
Lines 7419 7419
=========================================
Hits 7419 7419 Continue to review full report at Codecov.
|
|
📝 Docs preview for commit 73deb11 at: https://5fff5d61b3aa71452da3f60b--fastapi.netlify.app |
ycd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message subject should be "Make the default data type of tags value set"
You can also explain the reason in the body of the commit message
73deb11 to
36b063e
Compare
|
@cikay Changed it as you requested. Hope it's fine now. Thanks for the hint! |
|
Thanks for the effort @lukasgee! 🍪 And thanks for the help @ycd! ☕ Thanks for the interest @cikay, but the commit message is not too important, when I merge I use squash, and I update the PR title before that to keep it consistent with the other commits. This was covered in a recent PR, so I'm gonna close this one now. |
Fixed incorrect default value for the
tagsof typeSetfrom the list[]to the actual setset()according to initial type.