Skip to content

Conversation

@rodrigo-arenas
Copy link
Contributor

This pull requests adds the article "Serve a machine learning model using Sklearn, FastAPI and Docker" to the english external links documentation.
The article itself includes an explanation and tutorial to use:

  • FastAPI app with a machine learning model for online predictions
  • Use of FastAPI with the Docker Image: tiangolo/uvicorn-gunicorn:python3.8-slim
  • Load test using locust
  • Use of auto generated docs (OpenAPI)

@rodrigo-arenas rodrigo-arenas changed the title [Docs] Medium article FastAPI with Docker and Sklearn Update external_links.yml (Serve a machine learning model using Sklearn, FastAPI and Docker) Mar 21, 2021
Copy link
Contributor

@ArcLightSlavik ArcLightSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@app.post('/predict', tags=["predictions"])
You should probably have the tags on the APIRouter rather than the endpoint.
Love the locust part 🙂

@rodrigo-arenas
Copy link
Contributor Author

Thank you @ArcLightSlavik for your feedback, I'm glad you enjoyed it, I'll keep it in mind and update it the tags to the APIRouter

@tiangolo tiangolo changed the title Update external_links.yml (Serve a machine learning model using Sklearn, FastAPI and Docker) 📝 Add external link: Serve a machine learning model using Sklearn, FastAPI and Docker Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #2974 (95ca308) into master (bcd06fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2974   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          254       254           
  Lines         7855      7855           
=========================================
  Hits          7855      7855           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd06fd...95ca308. Read the comment docs.

@tiangolo tiangolo merged commit b9fed9b into fastapi:master Jul 21, 2021
@tiangolo
Copy link
Member

Great, thanks for your contribution @rodrigo-arenas ! 📝

solomein-sv pushed a commit to solomein-sv/fastapi that referenced this pull request Jul 30, 2021
…stAPI and Docker (fastapi#2974)

Co-authored-by: rodrigoarenas456 <31422766+rodrigoarenas456@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants