Skip to content

Use proper import for Request -- fixes #492#493

Merged
tiangolo merged 1 commit intofastapi:masterfrom
kamalgill:bugfix-492-fix-request-import
Sep 1, 2019
Merged

Use proper import for Request -- fixes #492#493
tiangolo merged 1 commit intofastapi:masterfrom
kamalgill:bugfix-492-fix-request-import

Conversation

@kamalgill
Copy link
Contributor

Fixes #492

@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #493 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #493   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         251    251           
  Lines        5988   5988           
=====================================
  Hits         5988   5988
Impacted Files Coverage Δ
fastapi/exceptions.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203e105...9ffcf40. Read the comment docs.

@tiangolo tiangolo merged commit 4642f63 into fastapi:master Sep 1, 2019
@tiangolo
Copy link
Member

tiangolo commented Sep 1, 2019

Good catch! 🔍 🕵️‍♂️ Thanks! 🍰 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FastAPI exceptions module mistakenly references the 'requests' package

3 participants