Skip to content

Conversation

@tiangolo
Copy link
Member

@tiangolo tiangolo commented Feb 4, 2020

✅ Lint first in tests, to error out faster

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #948 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #948   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         293    293           
  Lines        7704   7704           
=====================================
  Hits         7704   7704
Impacted Files Coverage Δ
...est_additional_responses_custom_validationerror.py 100% <0%> (ø) ⬆️
docs/src/app_testing/tutorial003.py 100% <0%> (ø) ⬆️
...t_query_params_str_validations/test_tutorial001.py 100% <0%> (ø) ⬆️
tests/test_custom_swagger_ui_redirect.py 100% <0%> (ø) ⬆️
docs/src/first_steps/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_additional_responses_router.py 100% <0%> (ø) ⬆️
docs/src/application_configuration/tutorial001.py 100% <0%> (ø) ⬆️
...test_tutorial/test_body_fields/test_tutorial001.py 100% <0%> (ø) ⬆️
tests/test_swagger_ui_init_oauth.py 100% <0%> (ø) ⬆️
tests/test_duplicate_models_openapi.py 100% <0%> (ø) ⬆️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e0a102...a0f5702. Read the comment docs.

@tiangolo tiangolo merged commit 9573130 into master Feb 4, 2020
@tiangolo tiangolo deleted the test-lint-first branch February 4, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants