Prevent propagation of scopes on non-security sub-dependencies#9790
Closed
DurandA wants to merge 1 commit intofastapi:masterfrom
Closed
Prevent propagation of scopes on non-security sub-dependencies#9790DurandA wants to merge 1 commit intofastapi:masterfrom
DurandA wants to merge 1 commit intofastapi:masterfrom
Conversation
|
Hi @tiangolo, |
YuriiMotov
reviewed
Feb 21, 2024
Member
YuriiMotov
left a comment
There was a problem hiding this comment.
I see a problem in this implementation.
I described it in the discussion here
Let's discuss it there
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
Member
|
Thanks for the discussion and effort here! 🍰 This should be solved by #14419, released in FastAPI 0.123.0 🎉 I'll close this one now. ☕ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2945 the behavior of cache keys was changed. The scopes are passed to every dependencies down the tree, including when these dependencies are not
Security.This results in undesired behaviors when a dependency such as a DB session is created twice, e.g.: