➖ Vendor Click and streamline Typer's functionality and code base#1774
Merged
Conversation
* vendor click 8.1.8 into subdir _click for now * use full version to avoid confusion (for now) * few import fixes in the vendored files * fix stderr test * switch to Click 8.3.1 * remove deprecation warnings for Click 9.0 * update uv lock * 🎨 Auto format * remove Python 3.9 test * avoid ruff E402 warning * remove code paths for Click < 8.2 * 🎨 Auto format * remove unused variable * remove more code specific only to <8.2 * 🎨 Auto format * remove using_click documentation * remove reference to Click design difference * clean up click decorators code * remove command and group from click's core * remove Click's shell_complete (Typer overwrites it) * restore Click's shell_complete for now * format * 🎨 Auto format --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
# Conflicts: # typer/main.py
…pstream_drop_click
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Contributor
svlandeg
commented
May 20, 2026
svlandeg
commented
May 20, 2026
svlandeg
changed the title
svlandeg
commented
May 21, 2026
github-actions
Bot
added
the
conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
Bot
added
conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
Bot
removed
the
conflicts
tiangolo
approved these changes
May 26, 2026
Member
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Amazing, thank you! Let's release this! 🚀
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR vendors Click 8.3.1, removes some unused functionality, drops support for Click-only features, and adds a bunch of unit tests to bring Typer's test coverage back to 100%.
There should be no breaking features with respect to functionality documented in Typer's documentation / Typer's public-facing API. But users relying on the fact that Typer used Click underneath, might have to refactor their application. Any code in the new subfolder
typer/_clickshould not be used by external applications, as it will be subject to change in the near future.More information about how & why we vendored Click can be found here, and we'd love to take this opportunity to thank the Click team for all their work over the years 🙏
Process
Path,Argument,Option,Group,Choice,ShellComplete): Merge Click and Typer functionality #1680tytype checker: Enabletyand resolve typing issues #1770@tiangolo: as you've already reviewed 1-5 in detail, you can focus on the docs changes in 6. Feel free to push to the branch directly if you want to reword some of this.