🐛 Ensure that an envvar set for typer.Option works as expected#1788
Merged
Conversation
svlandeg
changed the title
typer.Option works as expected
tiangolo
approved these changes
May 26, 2026
Member
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Awesome, thanks! So fast. 🚤
This will be available in Typer 0.26.1 in the next few minutes.
YuriiMotov
reviewed
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1787, thanks to @wpk-nist-gov for the report in #1786.
Description
In the Click vendoring PR leading up to release 0.26.0, at a certain point I merged Click's
OptionwithTyperOption. For the functionvalue_from_envvar(original here) I removed some flag-related stuff that shouldn't be relevant to Typer, but I must have mistakingly also removed the final return statementreturn rvwhen there is a relevant envvar set. The commit that produced this bug was this one.There wasn't a regression test to catch this, so this PR adds one.
AI Disclaimer
Used Cursor to help me debug the issue more quickly, manually reviewed everything in detail.
Checklist