[BUG] Logo and Information Panel is not align in vscode terminal

[hyuckkim]

Read the FAQ first

• I have checked the FAQ but the issue is not covered

Description

I thought the information panel would be attached to the top row.
However, it is displayed slightly differently in VS Code.
The list is displayed after 3 or 5 blank lines, and that many blank lines appear below the logo.

It displays normally in other terminals.

same in ubuntu also.

Version used

fastfetch 2.60.0 (x86_64) / fastfetch 2.59.0 (x86_64)

Bug prevalence

Always

Regression

Not sure

Installation

Package manager

Package manager

winget / ppa:zhangsongcui3371/fastfetch

Screenshots

No response

Configuration

{
  "$schema": "https://github.com/fastfetch-cli/fastfetch/raw/dev/doc/json_schema.json",
  "modules": [
    "title",
    "separator",
    "os",
    "host",
    "kernel",
    "uptime",
    "shell",
    "display",
    "cpu",
    "gpu",
    "memory",
    "disk",
    "localip",
    "battery",
    "break",
    "colors"
  ]
}

Image protocol

no image.

Terminal

VSCode terminal

Image tried

no image.

Error message

root@DESKTOP-57OVK8I:~# fastfetch -s none --show-errors
....
.',:clooo: .:looooo:.
.;looooooooc .oooooooooo'
.;looooool:,''. :ooooooooooc
;looool;. 'oooooooooo,
;clool' .cooooooc. ,, none:
... ...... .:oo,

Features built-in

threads
vulkan
wayland
xcb-randr
xrandr
drm
drm_amdgpu
gio
dconf
dbus
imagemagick6
chafa
zlib
sqlite3
rpm
egl
glx
opencl
libpulse
libddcutil
libelf
libzfs
Directx Headers
linux/videodev2
linux/wireless

[CarterLi]

Just make your terminal higher

It is a known limitation but wont be fixed

[hyuckkim]

Oh. So that was the problem.

Thank you for letting me know!

[paulchen5]

Hi @CarterLi , I am also interested in this. Could you explain why that happens within the vscode terminal if you have a clue already / point me to some of the probably relevant code for this problem so I may take a look by myself?

[CarterLi]

@paulchen5

What Fastfetch currently does:

1. Prints the full logo
2. Moves the cursor back to the first line (this is where the problem starts)
3. Prints user-defined modules

The issue is that if the terminal is shorter than the logo, the top part of the logo gets scrolled out of the viewport. Since there is no reliable way to programmatically scroll the terminal viewport back, the cursor can only move to the first visible line of the viewport, which is below the actual top of the logo.

https://github.com/fastfetch-cli/fastfetch/blob/dev/src/logo/logo.c#L278

[paulchen5]

Ok, thanks for your response. So a suitable solution would be the kinda to dump the logo (positioned) + specs into a whole text and writing the text afterwards line by line. So therefore you would avoid the initial problem to readjust the cursor tho a position which doesn't exist anymore. However this could probably cause problems if the logo + specs are wider than the terminal width. So this would need to be cutted to the terminal width in advance.

However this would probably break all of your current writing / printing logic?

[paulchen5]

Another solution would be to calculate an offset for the cursor positioning? Determined by the length of the printed logo and placement of the logo and the available height to crop the first metrics if they don't fit into the terminal window.

[CarterLi]

crop the first metrics if they don't fit into the terminal window.

Won't people complain that some lines disappear?

[paulchen5]

Hm probably yeah. For me personal it wouldn't be a problem however I get the point.