Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the zpool module’s format-variable help so it accurately reflects the placeholders accepted by the runtime formatter, and improves CLI help alignment when placeholders exceed the previous fixed width.
Changes:
- Fix
zpoolformat placeholder names inffZpoolModuleInfo.formatArgsto match the actual runtime format keys. - Update
printCommandFormatHelpto compute a dynamic alignment width (with a 20-character minimum) based on the longest placeholder.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/modules/zpool/zpool.c |
Corrects documented zpool format placeholder names to match the FF_ARG(..., "<name>") keys used during formatting. |
src/fastfetch.c |
Dynamically adjusts format-help column width (min 20) to keep output aligned for long placeholders. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two related issues in
zpoolformat help.First, it corrects the documented
zpoolformat placeholders so thatfastfetch -h zpool-formatmatches the placeholders actually accepted atruntime.
Second, it fixes help output alignment for long format placeholders by keeping
the existing minimum width and expanding it dynamically when needed.
No existing related issue was found in the current issue tracker.
Related issue
N/A
Changes
zpoolformat placeholder names inffZpoolModuleInfo.formatArgsprintCommandFormatHelpBefore
After
Checklist