Conversation
Fixes Chrome support
Until some can confirm it works
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Prepares the v2.63.1 release by bumping the project version and documenting/packaging several Linux fixes (media length parsing, command option crash fix, and Wi‑Fi netlink behavior on certain architectures).
Changes:
- Bump version to 2.63.1 and update CHANGELOG for the release.
- Adjust Linux media length parsing for MPRIS metadata.
- Gate Linux Wi‑Fi netlink detection and update Debian packaging dependencies.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/detection/wifi/wifi_linux.c | Conditionally compiles netlink Wi‑Fi detection based on endianness and adjusts related declarations/usage. |
| src/detection/media/media_linux.c | Switches MPRIS length parsing to signed integer and ignores non-positive durations. |
| src/common/impl/commandoption.c | Changes JSON-result emission condition to rely on presence of resultDoc. |
| debian/control | Adds libefl-all-dev to build dependencies. |
| debian/changelog.tpl | Adds new Debian changelog entries for 2.63.0 and 2.62.1 templates. |
| CMakeLists.txt | Bumps project version to 2.63.1. |
| CHANGELOG.md | Adds 2.63.1 notes and clarifies dependency wording. |
|
|
||
| // Silence warning of `NLA_HDRLEN` and `NLA_ALIGN` | ||
| #pragma GCC diagnostic ignored "-Wsign-conversion" | ||
| #if !__BIG_ENDIAN__ |
| #if !__BIG_ENDIAN__ | ||
| #include <linux/genetlink.h> | ||
| #include <linux/nl80211.h> | ||
|
|
| Bugfixes: | ||
| * Fixes media length detection for Chrome on Linux (Media, Linux) | ||
| * Fixes segmentation fault when specifying unsupported modules on command line | ||
| * Disables usage of Netlink for Wi-Fi detection on s390x architectures (Wifi, Linux) |
Comment on lines
+98
to
101
| int64_t length = 0; // microseconds | ||
| if (ffDBusGetInt(data, &dictIterator, &length) && length > 0) { | ||
| result->length = (uint32_t) (length / 1000); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist