Skip to content

Add proper TidalShell version support to fastfetch#2428

Closed
cerealdevv wants to merge 6 commits into
fastfetch-cli:devfrom
cerealdevv:dev
Closed

Add proper TidalShell version support to fastfetch#2428
cerealdevv wants to merge 6 commits into
fastfetch-cli:devfrom
cerealdevv:dev

Conversation

@cerealdevv

@cerealdevv cerealdevv commented Jun 30, 2026

Copy link
Copy Markdown

Summary

This PR adds native version detection and proper process tree handling for TidalShell (https://github.com).

Changes

  • terminalshell.c: Added getShellVersionTidalshell helper. It invokes tidalshell -v (introduced in TidalShell 0.2-Nightly), trims trailing spaces, and isolates the numeric version by stripping out build tags (e.g., -Nightly).
  • terminalshell_linux.c: Added tidalshell to the known shells ignore array inside getTerminalInfo. This prevents Fastfetch from misidentifying the shell as a terminal emulator on Linux systems.
  • terminalshell_windows.c: Added proper case mapping in setShellInfoDetails so the UI cleanly displays TidalShell.

Checklist

  • I have tested my changes locally.

Notes for Reviewers

I'm primarily a C# & PowerShell developer. I do not have a local C/C++ compilation environment set up for fastfetch, therefore these changes have NOT been tested locally yet.

Please review my code. as I stated, I am not primarily a C/C++ developer. I am not as experienced in it.
I do not know if my code is efficient nor if it meets fastfetch quality standards.

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@CarterLi

CarterLi commented Jul 1, 2026

Copy link
Copy Markdown
Member

these changes have NOT been tested locally yet

No, especially for a random shell I've never heard of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants