Add proper TidalShell version support to fastfetch#2428
Closed
cerealdevv wants to merge 6 commits into
Closed
Conversation
Contributor
Up to standards ✅🟢 Issues
|
Member
No, especially for a random shell I've never heard of. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds native version detection and proper process tree handling for TidalShell (https://github.com).
Changes
terminalshell.c: AddedgetShellVersionTidalshellhelper. It invokestidalshell -v(introduced in TidalShell 0.2-Nightly), trims trailing spaces, and isolates the numeric version by stripping out build tags (e.g.,-Nightly).terminalshell_linux.c: Addedtidalshellto the known shells ignore array insidegetTerminalInfo. This prevents Fastfetch from misidentifying the shell as a terminal emulator on Linux systems.terminalshell_windows.c: Added proper case mapping insetShellInfoDetailsso the UI cleanly displaysTidalShell.Checklist
Notes for Reviewers
I'm primarily a C# & PowerShell developer. I do not have a local C/C++ compilation environment set up for fastfetch, therefore these changes have NOT been tested locally yet.
Please review my code. as I stated, I am not primarily a C/C++ developer. I am not as experienced in it.
I do not know if my code is efficient nor if it meets fastfetch quality standards.