Merged
Conversation
Member
|
I like these changes, so I am going to merge them and then report back on the results. |
Member
|
Verified. I have updated simple_fastfloat_benchmark so that it works with your latest release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These inlines seem to me to bring ffc.h and fast_float to parity in the benchmarks. But I'm also getting a bit turned around and confused; @lemire would you mind running benchmarks on your machine with latest ffc and these changes?
The change is logical; we wouldn't want any of these dispatch shims not getting inlined
I am curious what you get.
