Misc improvements #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, it only supports strictly positive floats (cassioneri/teju_jagua#5 (comment)) so we have to manually treat 0 separately
- uniform: we can now selectively generate only in [0, 1] or among all possible floats - new centered/non-centered generators
Member
|
On my todo |
lemire
approved these changes
May 22, 2025
Member
lemire
left a comment
lemire
left a comment
There was a problem hiding this comment.
Sorry for the delay.
Ok so non-centered means that the mantissa is zero (well, all but the virtual most significant bit)?
Member
|
I am going to merge this, since I cannot image why we wouldn't merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes various improvements:
exhaustivefloat32test (the value 0 needed to be considered separately).just_stringevaluation in all our tables. A new flag is available so that we can enable this only when necessary.