-
-
Notifications
You must be signed in to change notification settings - Fork 12
Bump fastify to v2 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "fastify": ">=1.13.0" | ||
| "fastify": ">=2.0.0-rc.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might cause trouble down the line. We should remove the peerDependency completely, it's not really needed as it's checked by fastify-plugin
1 similar comment
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit
|
@mcollina How do we progress with these ones? Bump minor/major and release now or wait for the v2 stable? |
|
just do a major release, but tag it as ‘next’. We’ll retag once fastify is out of rc. |
|
Wow you are too fast! It'ok anyway, well done! (and thanks) |
|
@allevo no problem, didn't require many changes after the previous PR actually so I just thought I should land it 😄 Thanks for the support! Now that I think maybe this could also work with something around Fastify |
|
Yes I think so. |
This looks good to go now 👍