fix: add types and updated docs for 'preRewrite'. #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mcollina
reviewed
Dec 2, 2025
types/index.d.ts
Outdated
| preHandler?: preHandlerHookHandler; | ||
| beforeHandler?: preHandlerHookHandler; | ||
| preValidation?: preValidationHookHandler; | ||
| preRewrite?: (url: string, params: unknown, prefix: string) => string; |
Member
There was a problem hiding this comment.
Can you add a test for this type? We use tsd.
Contributor
Author
There was a problem hiding this comment.
I've never worked with tsd so the latest commit is just a best guess, please take a look.
Member
There was a problem hiding this comment.
Can you follow the same structure as before? define a preRewriteHookHandler type.
Contributor
Author
There was a problem hiding this comment.
Sorry, managed to destroy my fork completely, created a new PR #442.
mn4367
force-pushed
the
prerewrite-types
branch
from
8ddbdf3 to
8597a2c
Compare
mn4367
force-pushed
the
prerewrite-types
branch
from
8597a2c to
efcb312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added types and updated docs for
preRewrite.