Skip to content

Conversation

@Jelenkee
Copy link
Contributor

Just a fix for a bug I found yesterday.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9969e30 into fastify:master Apr 14, 2021
@climba03003
Copy link
Member

Doesn't https://github.com/fastify/fastify-static/blob/master/index.js#L46 already merged sendOptions.root ?
Why we need to pass one more times on https://github.com/fastify/fastify-static/blob/master/index.js#L165 ?

@Jelenkee
Copy link
Contributor Author

@climba03003 It is merged. But the root may be an array. And the send stream cannot handle an array as root. That's why it is transformed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants