-
-
Notifications
You must be signed in to change notification settings - Fork 95
fix: return reply in async handlers #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for agitated-mahavira-26f8f9 canceled.
|
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
It looks like the CI jobs are failing to install pnpm. |
I fixed this issue. @LeanidShutau Can you try rebasing and pushing again to run the CI? |
@onlywei The fix is not merged into |
5c6b677 to
c31e395
Compare
Co-authored-by: Leanid Shutau <leanidshutau@gmail.com>
Fixes #292 by returning
replyobject fromasyncFastify handlers where it's missing.According to the Fastify docs,
replymust be returned fromasynchandler to avoid race conditions.