Skip to content

Conversation

@LeanidShutau
Copy link
Contributor

Fixes #292 by returning reply object from async Fastify handlers where it's missing.
According to the Fastify docs, reply must be returned from async handler to avoid race conditions.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2025

⚠️ No Changeset found

Latest commit: c31e395

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for agitated-mahavira-26f8f9 canceled.

Name Link
🔨 Latest commit c31e395
🔍 Latest deploy log https://app.netlify.com/projects/agitated-mahavira-26f8f9/deploys/68cc71ef15a86300089be52d

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onlywei
Copy link
Collaborator

onlywei commented Sep 16, 2025

It looks like the CI jobs are failing to install pnpm.

@onlywei
Copy link
Collaborator

onlywei commented Sep 17, 2025

It looks like the CI jobs are failing to install pnpm.

I fixed this issue. @LeanidShutau Can you try rebasing and pushing again to run the CI?

@LeanidShutau
Copy link
Contributor Author

It looks like the CI jobs are failing to install pnpm.

I fixed this issue. @LeanidShutau Can you try rebasing and pushing again to run the CI?

@onlywei The fix is not merged into dev yet, so my branch is up-to-date

@onlywei onlywei merged commit 7a43754 into fastify:dev Sep 18, 2025
5 checks passed
onlywei pushed a commit that referenced this pull request Jan 12, 2026
onlywei added a commit that referenced this pull request Jan 12, 2026
Co-authored-by: Leanid Shutau <leanidshutau@gmail.com>
@github-actions github-actions bot mentioned this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants