docs: inject chainable methods (#1917)#2043
Merged
mcollina merged 2 commits intofastify:masterfrom Jan 21, 2020
Merged
Conversation
jsumners
reviewed
Jan 17, 2020
docs/Testing.md
Outdated
| }) | ||
| ``` | ||
|
|
||
| you can also use chaining methods if you do not pass the callback function |
Member
There was a problem hiding this comment.
Suggested change
| you can also use chaining methods if you do not pass the callback function | |
| `.inject` methods can also be chained by omitting the callback function: |
Eomm
reviewed
Jan 18, 2020
docs/Testing.md
Outdated
| .get('/') | ||
| .headers({ foo: 'bar' }) | ||
| .query({ foo: 'bar' }) | ||
| .end((err, res) => { |
Member
There was a problem hiding this comment.
Suggested change
| .end((err, res) => { | |
| .end((err, res) => { // the .end call will trigger the request |
delvedor
approved these changes
Jan 18, 2020
Member
delvedor
left a comment
delvedor
left a comment
There was a problem hiding this comment.
LGTM with the suggestions above.
Contributor
Author
|
Sorry guys, so i add both the changes and we are good to go? |
Member
|
@alemagio did you forget to push the changes? |
Contributor
Author
Nono, i didn't get if you want me to apply both of the suggestions |
Member
|
They are suggestions for improvement and one reviewer said the PR will be acceptable with them applied. |
Contributor
Author
|
Ok, great. |
Eomm
approved these changes
Jan 21, 2020
This was referenced Jan 22, 2020
This was referenced Mar 20, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a reference to chainable methods on 'inject' function based on the update of 'light-my-request'
Checklist
npm run testandnpm run benchmark