Conversation
mcollina
force-pushed
the
add-http2-session-timeout
branch
from
735d1f0 to
4823edd
Compare
jsumners
reviewed
Jan 20, 2020
This commit adds an option http2SessionTimeout to be able to gracefully closing an http2 server. This is analogous to the 5000ms timeout of keepalive connections.
mcollina
force-pushed
the
add-http2-session-timeout
branch
from
4823edd to
6801443
Compare
Eomm
reviewed
Jan 22, 2020
| }) | ||
|
|
||
| // Skipped because there is likely a bug on Node 8. | ||
| t.test('http/2 closes successfully with async await', { skip: semver.lt(process.versions.node, '10.15.0') }, async t => { |
Member
There was a problem hiding this comment.
Could we add a test also that check session.on('timeout', () => { t.pass('timeout out reached') }); ?
Eomm
approved these changes
Jan 23, 2020
delvedor
added
semver-minor
This was referenced Jan 25, 2020
This was referenced Mar 20, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an option http2SessionTimeout to be able to gracefully
closing an http2 server. This is analogous to the 5000ms timeout of
keepalive connections.
Checklist
npm run testandnpm run benchmark