docs: add warning about empty string coercion with nullable types#6452
Merged
Conversation
github-actions
Bot
added
the
documentation
Eomm
reviewed
Jan 17, 2026
Eomm
reviewed
Jan 17, 2026
Contributor
Author
|
Hi @Eomm I've added the regression test for the empty string coercion as discussed (commit ee83489). It looks like the GitHub Workflows are waiting for approval to run. Could you please approve the CI run so we can verify the tests pass? I've also updated the branch to keep it current. Thanks! |
Contributor
Author
Member
|
@ritambh888 lint is failing |
Contributor
Author
@gurgunday Yes, I fixed it now. Please re-run the tests. |
Member
|
@Eomm ptal |
Fdawgs
reviewed
Mar 6, 2026
Eomm
reviewed
Mar 7, 2026
Fdawgs
requested changes
Mar 7, 2026
Fdawgs
approved these changes
Mar 7, 2026
gurgunday
approved these changes
Mar 7, 2026
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Ritam Bhattacharjee <151223264+ritambh888@users.noreply.github.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Ritam Bhattacharjee <151223264+ritambh888@users.noreply.github.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Eomm
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct