Skip to content

Fix clearing timeout using clearTimeout#218

Merged
Uzlopak merged 1 commit intofastify:masterfrom
karankraina:karankraina-patch-1
Jun 2, 2024
Merged

Fix clearing timeout using clearTimeout#218
Uzlopak merged 1 commit intofastify:masterfrom
karankraina:karankraina-patch-1

Conversation

@karankraina
Copy link
Contributor

Checklist

Signed-off-by: Karan Raina <karanraina1996@gmail.com>
@karankraina
Copy link
Contributor Author

@mcollina Could you please have a look at this. I think we should clear the timeouts using clearTimeout instead of setInterval

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karankraina
Copy link
Contributor Author

Thanks @mcollina @gurgunday. Checks have completed, it can be merged now.

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

At some Point we switched from a interval to a timeout and never set the right clear function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments