Skip to content

Conversation

@yiliansource
Copy link
Contributor

@yiliansource yiliansource commented Oct 8, 2021

Fixes #6

This PR fixes a couple of minor issues with the site.

  • The meta embed title was incorrect for the News section of the site (Change embed title #6).
  • Redundant comments in the configuration.
  • @docusaurus/preset-classic does not accept/support configuration objects wiki & news. These have been removed and their respective configurations have been merged into blog & docs, respectively.
  • Removed sidebar.js, since it's unused and the sidebar is currently auto-generated.
  • Fixed the edit base path, so now the URLs correctly point to the repository.

@lucasstarsz lucasstarsz linked an issue Oct 8, 2021 that may be closed by this pull request
@lucasstarsz lucasstarsz removed a link to an issue Oct 8, 2021
Copy link
Member

@lucasstarsz lucasstarsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to FastJ! It's much appreciated 😃
Please look over my review comments when you have some time.

@lucasstarsz lucasstarsz self-requested a review October 8, 2021 16:09
@lucasstarsz lucasstarsz merged commit 7853499 into fastjengine:main Oct 8, 2021
@yiliansource yiliansource deleted the fix/page-metas branch October 8, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change embed title

2 participants