Feature/development assistance, closes #11 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasstarsz
requested changes
Oct 8, 2021
Member
lucasstarsz
left a comment
lucasstarsz
left a comment
There was a problem hiding this comment.
Thanks for making a PR, it's much appreciated!
This is quite the big change, and I'm really liking what you've accomplished here. Hopefully the GitHub Action script works out first time in, too.
Anyways, please look over the comments I made.
lucasstarsz
approved these changes
Oct 10, 2021
Member
lucasstarsz
left a comment
lucasstarsz
left a comment
There was a problem hiding this comment.
Looks alright to me. Thanks for contributing to FastJ!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the tasks mentioned in #11. For reference, see the issue.
The workflows have not been tested, but have proven to work for different projects. A proper test is only possible after merging.