Reconfigure the linter and formatter correctly. And reflect it throughout. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuji44
commented
Oct 30, 2022
|
|
||
| [flake8] | ||
| max-line-length = 88 | ||
| extend-ignore = E203,E501 |
Contributor
Author
There was a problem hiding this comment.
E501は行の文字数チェックです。
このチェックは、ほとんどの場合はblackで88行にフォーマットされるため回避できます。長い文字列やコメント行などはblackが無視するための残りますが、モダンな開発環境では文字数の切りつめがそれほど重要でなく、切り詰めるためだけにコード変更を行うのは本末転倒だと考え、無効化しました。
| repos: | ||
| - repo: https://github.com/psf/black | ||
| rev: 20.8b1 | ||
| rev: 22.10.0 |
Contributor
Author
There was a problem hiding this comment.
#125 の問題。
issueに書いた回避策では pre-commit で動作しなかったため、バージョンアップで対処。
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
プロダクトコードのフォーマットが整っていなかったため確認したところ、black、isort、flake8、pre-commitの設定が適切でなく、正しく動作しづらい状態でした。
そこでそれぞれの設定の見直しと、全体を再フォーマットしました。
fix: #125